tag combination broken?
ForumBug Collectors
Melde dich bei LibraryThing an, um Nachrichten zu schreiben.
1parlerodermime
Hi,
Proposal of tag combinations seems to be broken (either that, or something with the tag detail display page). I'm on a current version of Google Chrome on a Windows machine, and stumbled upon this example:
I noticed both tags "secret-baby" and "secret baby" were showing up on the same book and made sense to combine. When I clicked the Combine/Separate link on the tag page, however, I got into a weird loop where it was like I was going into a different top-level tag instead of the tag page. Is it possible that something is going on with the recent fix for special characters in tags, and now the tag detail page is showing up as a different tag where the site is assuming "detail/tagname" is the tag name?
Here's a screenshot:
All that said, I LOVE that tags with special features work again, and tag combinations haven't worked for a while anyway, so please don't take away the special character fix on tags! If anything, I wouldn't mind a "tag combination" page where you could go and suggest "tag1" and "tag2" should be combined (and also see the voting going on for preexisting tag combinations and their status). Moving it from the detail page to a tag combiners page would probably help reduce the number of mistaken tag combination proposals that are made instead of tagmashes too.
Proposal of tag combinations seems to be broken (either that, or something with the tag detail display page). I'm on a current version of Google Chrome on a Windows machine, and stumbled upon this example:
I noticed both tags "secret-baby" and "secret baby" were showing up on the same book and made sense to combine. When I clicked the Combine/Separate link on the tag page, however, I got into a weird loop where it was like I was going into a different top-level tag instead of the tag page. Is it possible that something is going on with the recent fix for special characters in tags, and now the tag detail page is showing up as a different tag where the site is assuming "detail/tagname" is the tag name?
Here's a screenshot:
All that said, I LOVE that tags with special features work again, and tag combinations haven't worked for a while anyway, so please don't take away the special character fix on tags! If anything, I wouldn't mind a "tag combination" page where you could go and suggest "tag1" and "tag2" should be combined (and also see the voting going on for preexisting tag combinations and their status). Moving it from the detail page to a tag combiners page would probably help reduce the number of mistaken tag combination proposals that are made instead of tagmashes too.
2karenb
I am seeing this too.
Clicking on Helpers > Combine/Separate Tags adds another "detail/" (I stopped at four).
Using Firefox (latest) on Windows 10 (up to date).
Clicking on Helpers > Combine/Separate Tags adds another "detail/" (I stopped at four).
Using Firefox (latest) on Windows 10 (up to date).
4Bernarrd
Links from some tags in book listings seem to be broken. When clicked on they show a message saying "No books found in this collection". One such tag is "F. Tennyson Neely". Oddly if I go to the Tags list and click on the tag it shows book referred to. I also had a link from my Home page to a group of books show as nothing connected to the link.
5shadrach_anki
>3 gilroy: Given that the screenshot shows a + in the link, could it be connected to this one?
https://www.librarything.com/topic/349242
Or one of several other recently discussed/fixed bugs that deal with the + sign showing up or not showing up. I have to wonder if they aren't all connected....
https://www.librarything.com/topic/349242
Or one of several other recently discussed/fixed bugs that deal with the + sign showing up or not showing up. I have to wonder if they aren't all connected....
6knerd.knitter
Verified. Assigning to ccatalfo
8parlerodermime
I think there's still a glitch, but at this point, it might just be a couple straggling places where the function has been restored but the link to get to the function isn't yet correct.
I just went to the "secret-baby" tag page (https://www.librarything.com/tag/secret-baby) to combine it with "secret baby". When I clicked the combine/separate tags helper link on the right sidebar, it directed me to a combine/separate page for a non-existent tag: "(secret-baby)". See: https://www.librarything.com/tag/detail/%28secret-baby%29#combinations
I tested out the combination anyway, and it just submitted a tag combination proposal for (secret-baby) and secret baby, so the parentheses weren't protecting the tag.
Sidenote: On this page, clicking the link for the tag "secret baby" went to "secret+baby" instead (https://www.librarything.com/tag/secret+baby) and since "secret+baby" isn't a tag people have used, it didn't actually populate with any data.
Then, I manually edited the URL to remove the %28 and %29. This did result in a tag combination proposal page where I seem successfully to have submitted a combination proposal for "secret-baby" and "secret baby".
I just went to the "secret-baby" tag page (https://www.librarything.com/tag/secret-baby) to combine it with "secret baby". When I clicked the combine/separate tags helper link on the right sidebar, it directed me to a combine/separate page for a non-existent tag: "(secret-baby)". See: https://www.librarything.com/tag/detail/%28secret-baby%29#combinations
I tested out the combination anyway, and it just submitted a tag combination proposal for (secret-baby) and secret baby, so the parentheses weren't protecting the tag.
Sidenote: On this page, clicking the link for the tag "secret baby" went to "secret+baby" instead (https://www.librarything.com/tag/secret+baby) and since "secret+baby" isn't a tag people have used, it didn't actually populate with any data.
Then, I manually edited the URL to remove the %28 and %29. This did result in a tag combination proposal page where I seem successfully to have submitted a combination proposal for "secret-baby" and "secret baby".
9ccatalfo
>8 parlerodermime: thanks for the report, will take another look.